-
Notifications
You must be signed in to change notification settings - Fork 87
when enabling sql extensions, enable their pdo counterparts #116
base: master
Are you sure you want to change the base?
Conversation
this doesn't do much, as of yet. |
|
||
exec { "${command} -s cli ${extension}": | ||
creates => "/etc/php5/cli/conf.d/${priority}-${extension}.ini", | ||
notify => Service['supervisor'], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you may want to remove this :)
don't think many people uses supervisor - in my case its used to reload all php workers processes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that said, being able to subscribe to these enable/disable execs is very useful
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nod
notify/subscribe are metaparameters, you can always pass them along.
i think it's time i take another look at this ;) |
haha yeah |
so! I just tested this on one of my prod systems and it seems to work out fine. next step should be to move the standard php::config case into php::extension, and remove all params classes. |
nizzle ! :) |
i'd love to get some more feedback / testing here ;) |
latest commit uses the correct prio for mysqlnd, not sure about the other drivers. again: need some feedback / testing from other people ;) |
*always* symlink extension to all (enabled) SAPIs all (both) mysql extensions point to the same pdo name/file. For mysql(nd) also manage mysqli inifile/settings
n.b.: all mysql extensions point to the same pdo name/file.
for mysql in particular, we also enable mysqli